Messages in this thread | | | Date | Sun, 25 Nov 2012 10:28:45 -0500 | From | Jason Cooper <> | Subject | Re: [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl |
| |
On Sun, Nov 25, 2012 at 11:51:46AM +0100, Sebastian Hesselbarth wrote: > On 11/24/2012 07:59 PM, Jason Cooper wrote: > >On Sat, Nov 24, 2012 at 07:10:24PM +0100, Thomas Petazzoni wrote: > >>On Sat, 24 Nov 2012 10:00:04 -0500, Jason Cooper wrote: > >>>Yes, so that's what I thought happened. This would have made orion/dt > >>>depend upon mvebu/everything. It already had two other dependencies. > >>>Not ideal. > >>> > >>>The good thing is, the build is not broken. Once v3.8-rc1 drops with > >>>all of our stuff merged, I'll post a fixup patch adding this back in. > >> > >>It unfortunately means that Dove will be basically unbootable in > >>3.8-rc1, as the driver will not be clk_get()ing its gatable clock, and > >>the clock driver will disable it. Maybe we can just live with it, I > >>don't know. > > > >Yes, I thought as much after I sent this reply. Definitely a choice of > >the lesser of two evils. As long as we don't break the build or have > >horrendous merge conflicts, I think it's tolerable. > > > >Any one who is booting -rc1's is typically bug hunting. This means > >Sebastian, who has been CC'd on all of this. I don't want to rely on > >this in the future, but doing it once due to the circumstances is > >something I'm comfortable answering to. > > sorry for the late answer. I merged all pull reqs in the order posted > on top of latest linux/master. Thomas is right, removing the clk_gate > from pinctrl potentially could have broken boot on dove. I tried it and > it _does_ boot, because the clk used by pinctrl is optional in pinctrl-dove > and there is no pinhog/device touching the register clocked by the clock. > > As soon as I 'cat pinconf-groups' in debugfs, the register is read and > my cubox hangs as expected. > > So, finally a fixup patch for 3.8-rc1 is ok for me.
Great! I'm glad to hear it's not as bad as I feared.
thx,
Jason.
| |