Messages in this thread | | | Date | Sun, 25 Nov 2012 11:45:43 +0100 | Subject | Re: [PATCH] ewrk3: silence GCC warning | From | richard -rw- weinberger <> |
| |
On Sat, Nov 24, 2012 at 1:12 PM, Paul Bolle <pebolle@tiscali.nl> wrote: > Building ewrk3.o triggers this GCC warning: > drivers/net/ethernet/dec/ewrk3.c: In function '__check_irq': > drivers/net/ethernet/dec/ewrk3.c:1915:1: warning: return from incompatible pointer type [enabled by default] > > This can be trivially fixed by changing the 'irq' parameter from int to > byte (which is the alias for unsigned char for module parameters). > > While we're touching this code also drop an outdated comment, that > should have been dropped with the patch named "MODULE_PARM conversions" > from early 2005.
Please send this change as an additional patch.
-- Thanks, //richard
| |