Messages in this thread | | | Date | Sat, 24 Nov 2012 17:08:02 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 5/7] uprobes: Introduce filter_chain() |
| |
On 11/23, Oleg Nesterov wrote: > > Change install_breakpoint() to call filter_chain() instead of checking > uprobe->consumers != NULL. We obviously need this, and this equally > closes the race with _unregister(). > > Change remove_breakpoint() to call this helper too. Currently this is > pointless because remove_breakpoint() is only called when the last > consumer goes away, but we will change this.
Just in case...
This is only to make the initial change as simple as possible. filter_chain() will have more arguments and more callers, say, perhaps build_map_info(). And perhaps these 2 callsites should be moved from install/remove to the caller later.
Oleg.
| |