Messages in this thread | | | Date | Sat, 24 Nov 2012 13:04:19 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults |
| |
On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: > A thp contributes 512 times more than a regular page to numa fault stats, > so deserves its own vm event counter. THP migration is also accounted. >
I agree and mentioned it needed fixing. I did not create a new counter but I properly account for PGMIGRATE_SUCCESS and PGMIGRATE_FAIL now. I did not create a new NUMA_PAGE_MIGRATE counter because I didn't feel it was necessary. Instead I just do this
count_vm_events(PGMIGRATE_SUCCESS, HPAGE_PMD_NR); count_vm_numa_events(NUMA_PAGE_MIGRATE, HPAGE_PMD_NR);
> [A duplicated computation of page node idx is cleaned up] >
Got it. Thanks
-- Mel Gorman SUSE Labs
| |