lkml.org 
[lkml]   [2012]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()
    From
    On 23 November 2012 12:49, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
    > Ahh, I see. Then I think my first patch was correct albeit it had bad changelog
    > message. If provided stubs for clk_prepare()/clk_unprepare() for
    > platforms that did not define HAVE_CLK and pushed the check for
    > HAVE_CLK_PREPARE down into drivers/clk/clk.c so __clk_prepare() would
    > either call platform implementation or just be an empty function.
    >
    > Am I correct or I am still missing something?

    I believe you are still missing it :)

    clk.c will only be compiled when we have COMMON_CLK and
    COMMON_CLK selects HAVE_CLK_PREPARE.

    So, using HAVE_CLK_PREPARE in clk.c is useless, as its always true.
    I feel, the best solution would be to simply drop patch 1 and apply others.

    --
    viresh


    \
     
     \ /
      Last update: 2012-11-23 09:01    [W:2.131 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site