lkml.org 
[lkml]   [2012]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFC v2 3/4] firmware: Add support for signature checks
    From
    Date
    於 四,2012-11-08 於 18:35 +0100,Takashi Iwai 提到:
    > +#ifdef CONFIG_FIRMWARE_SIG
    > +static int verify_sig_file(struct firmware_buf *buf, const char
    > *path)
    > +{
    > + const unsigned long markerlen = sizeof(FIRMWARE_SIG_STRING) -
    > 1;
    > + struct file *file;
    > + void *sig_data;
    > + size_t sig_size;
    > + int ret;
    > +
    > + file = filp_open(path, O_RDONLY, 0);
    > + if (IS_ERR(file))
    > + return -ENOKEY;

    I think there should return '-ENOENT', otherwise the firmware will show
    'Invalid firmware signature' even didn't find the sig file.

    > +
    > + ret = fw_read_file_contents(file, &sig_data, &sig_size);
    > + fput(file);

    Tested-by: Chun-Yi Lee <jlee@suse.com>

    Thanks a lot!
    Joey Lee

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-11-23 08:41    [W:2.693 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site