lkml.org 
[lkml]   [2012]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup
On 11/23/2012 11:45 AM, Shubhrajyoti Datta wrote:
> On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera
> <tushar.behera@linaro.org> wrote:
>> This patchset cleans up the probe function of i2c-s3c2410 driver.
>> These have been tested on Exynos4210 based Origen board.
>>
>> Tushar Behera (7):
>> i2c: s3c2410: Remove unnecessary label err_noclk
>> i2c: s3c2410: Convert to use devm_clk_get()
>> i2c: s3c2410: Convert to use devm_request_mem_region()
>> i2c: s3c2410: Convert to use devm_ioremap()
>> i2c: s3c2410: Convert to use devm_request_irq()
>
> You may want to consider request_and_ioremap.
>

Thanks. I will redo the patchset and submit again.

>
>> i2c: s3c2410: Move location of clk_prepare_enable() call in probe
>> function
>> i2c: s3c2410: Remove err_cpufreq label
>>
>> drivers/i2c/busses/i2c-s3c2410.c | 74 ++++++++++++--------------------------
>> 1 files changed, 23 insertions(+), 51 deletions(-)
>>
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html


--
Tushar Behera


\
 
 \ /
  Last update: 2012-11-23 08:41    [W:0.066 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site