Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Add --strict messages for blank lines around braces | From | Joe Perches <> | Date | Fri, 23 Nov 2012 09:24:33 -0800 |
| |
Blank lines around braces are not unnecessary. Emit a message on the use of these blank lines only when using --strict.
int foo(int bar) {
something or other....
}
is generally written in the kernel as:
int foo(int bar) { something or other... }
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 13ce29e..6d0247f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3184,6 +3184,16 @@ sub process { } } +# check for unnecessary blank lines around braces + if (($line =~ /^..*}\s*$/ && $prevline =~ /^.\s*$/)) { + CHK("BRACES", + "Blank lines aren't necessary before a close brace '}'\n" . $hereprev); + } + if (($line =~ /^.\s*$/ && $prevline =~ /^..*{\s*$/)) { + CHK("BRACES", + "Blank lines aren't necessary after an open brace '{'\n" . $hereprev); + } + # no volatiles please my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
| |