Messages in this thread | | | From | Peter Korsgaard <> | Subject | Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support | Date | Fri, 23 Nov 2012 13:48:51 +0100 |
| |
>>>>> "Thierry" == Thierry Reding <thierry.reding@avionic-design.de> writes:
Hi,
Thierry> Everybody seems to be doing it with a warning, so I guess Thierry> that's fine for now. I just find it strange that if you Thierry> request the default pin group to be selected when in fact the Thierry> hardware doesn't support pinctrl at all you shouldn't be Thierry> getting an error either.
There's several different situations:
- Platform without pinctrl support - Platform with pinctrl support but no pinmux specified in dt for device (E.G. pinmux setup in bootloader) - Pinmux specified in dt - Some kind of misconfiguration in dt
You could argue that devm_pinctrl_get_select_default() shouldn't return an error for the first situation, but how should it be able to know the difference between 2 and 4?
-- Bye, Peter Korsgaard
| |