Messages in this thread | | | From | "Philip, Avinash" <> | Subject | RE: [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver | Date | Fri, 23 Nov 2012 10:35:01 +0000 |
| |
On Fri, Nov 23, 2012 at 02:33:47, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:03PM +0530, Philip, Avinash wrote: > [...] > > +static const struct of_device_id ehrpwm_of_match[] = { > > + { > > + .compatible = "ti,am33xx-ehrpwm", > > + }, > > Same comment as for patch 4.
Ok I will correct it.
> > > @@ -437,16 +451,41 @@ static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev) > > dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret); > > return ret; > > } > > - > > I think this blank line actually improves readability so it can stay in.
I will add.
Thanks Avinash
> > Thierry >
| |