Messages in this thread | | | From | "Philip, Avinash" <> | Subject | RE: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support | Date | Fri, 23 Nov 2012 10:34:02 +0000 |
| |
On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > [...] > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > + if (IS_ERR(pinctrl)) > > + dev_warn(&pdev->dev, "failed to configure pins from driver\n"); > > I think we already discussed this, but shouldn't this be a fatal error?
I had checked relevant discussion and found this can be warning message. This is because most boards don't have pinctrl implemented at this point, or may never have.
https://lkml.org/lkml/2012/9/11/369
Any way I will change to dev_warn(&pdev->dev, "unable to select pin group\n"); as in other drivers.
Thanks Avinash
> > Thierry >
| |