lkml.org 
[lkml]   [2012]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship
Date
On Fri, Nov 23, 2012 at 02:17:04, Thierry Reding wrote:
> On Wed, Nov 21, 2012 at 06:40:58PM +0530, Philip, Avinash wrote:
> [...]
> > +static const struct of_device_id pwmss_of_match[] = {
> > + {
> > + .compatible = "ti,am33xx-pwmss",
> > + },
>
> For consistency with other drivers this should be all on one line.

Ok I will correct it.

>
> > +static const struct dev_pm_ops pwmss_pm_ops = {
> > + SET_SYSTEM_SLEEP_PM_OPS(pwmss_suspend, pwmss_resume)
> > +};
>
> This could be even shorter:
>
> static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);

Ok I will correct it.

Thanks
Avinash

>
> Thierry
>



\
 
 \ /
  Last update: 2012-11-23 12:21    [W:0.045 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site