Messages in this thread | | | From | "Philip, Avinash" <> | Subject | RE: [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship | Date | Fri, 23 Nov 2012 10:34:01 +0000 |
| |
On Fri, Nov 23, 2012 at 02:17:04, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:40:58PM +0530, Philip, Avinash wrote: > [...] > > +static const struct of_device_id pwmss_of_match[] = { > > + { > > + .compatible = "ti,am33xx-pwmss", > > + }, > > For consistency with other drivers this should be all on one line.
Ok I will correct it.
> > > +static const struct dev_pm_ops pwmss_pm_ops = { > > + SET_SYSTEM_SLEEP_PM_OPS(pwmss_suspend, pwmss_resume) > > +}; > > This could be even shorter: > > static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
Ok I will correct it.
Thanks Avinash
> > Thierry >
| |