Messages in this thread | | | Date | Fri, 23 Nov 2012 09:39:31 +0000 | From | Lee Jones <> | Subject | Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver |
| |
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 16:54, Lee Jones <lee.jones@linaro.org> wrote: > >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt > >> +Optional properties: > >> +- irq-trigger: IRQ trigger to use for the interrupt to the host > >> +- irq-invert-polarity: bool, IRQ line is connected with reversed polarity > > > > Are these new? > > > > When adding new bindings, ask yourself: > > I was trying to get information of these two bindings from other sources, > but couldn't find. The only other place can be the interrupts field, right?
Bingo. Continue along this thread.
> Because interrupts field depends on the interrupt controller, which can > be a wide variety of controllers in our case, we can't use that. Also, > the cells of interrupts field will have something that is required to be > programmed in the interrupt controller and not in the user of IC. > > But here we are talking about programming stmpe and so these bindings > are very much required in stmpe only.
Not true.
Hint: `git grep triggered -- Documentation/devicetree/`
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |