lkml.org 
[lkml]   [2012]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 11/12] x86, boot: add fields to support load bzImage and ramdisk high
On 11/22/2012 10:28 AM, Yinghai Lu wrote:
>
> has problem with old kexec, it only copy header from bzImage include
> setup_header as boot_param.
>

How old are we talking here? This is a clear and blatant bug, and it
would affect a whole bunch of things, not just this. In fact, one
really has to wonder how it can work at all.

One option I guess would be to have a sentinel field which, if it is not
zero, causes the kernel to zero all of struct setup_info outside of
setup_header... however, I have a nasty suspicion that this kexec botch
might be initializing some fields and leaving others unmodified, which
basically means "there is no hope for sanity and it is just working by
pure accident."

Eric, do you have any insight here?

> looks we only can use [0x30,0x3c), [0x1e8, 0x1f0), but in boot_params, they
> are apm_bios_info, and alt_mem_k...

... which I suspect get set by said kexec botch.

> so looks we still have to use setup_header instead.

We need to dig into this and either say "this is unsupportable" or put
in some kind of hack.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2012-11-26 02:01    [W:0.312 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site