lkml.org 
[lkml]   [2012]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm
On Thu, Nov 22, 2012 at 01:31:06PM +0100, Lothar Waßmann wrote:

> obj-$(CONFIG_SND_SOC_IMX_PCM) += snd-soc-imx-pcm.o
> snd-soc-imx-pcm-y := imx-pcm.o
> -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_FIQ) += imx-pcm-fiq.o
> -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_DMA) += imx-pcm-dma.o
> +ifneq ($(CONFIG_SND_SOC_IMX_PCM_FIQ),)
> + snd-soc-imx-pcm-objs += imx-pcm-fiq.o
> +endif
> +ifneq ($(CONFIG_SND_SOC_IMX_PCM_DMA),)
> + snd-soc-imx-pcm-objs += imx-pcm-dma.o
> +endif

What is the actual bug here? This fix doesn't look obviously right, and
if we do need to move to -objs for some reason then the block ought to
be in the -objs section of the Makefile.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-11-23 03:41    [W:0.081 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site