lkml.org 
[lkml]   [2012]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 34/83] i2c-mux-pinctrl: Fix probe error path
    Date
    3.6-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guenter Roeck <linux@roeck-us.net>

    commit aa1e3e81e75ceb3d977c3292cefafcd5179eb8b8 upstream.

    When allocating the memory for i2c busses, the code checked the wrong
    variable and thus never detected if there was a memory error.

    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/i2c/muxes/i2c-mux-pinctrl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/i2c/muxes/i2c-mux-pinctrl.c
    +++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c
    @@ -169,7 +169,7 @@ static int __devinit i2c_mux_pinctrl_pro
    mux->busses = devm_kzalloc(&pdev->dev,
    sizeof(mux->busses) * mux->pdata->bus_count,
    GFP_KERNEL);
    - if (!mux->states) {
    + if (!mux->busses) {
    dev_err(&pdev->dev, "Cannot allocate busses\n");
    ret = -ENOMEM;
    goto err;



    \
     
     \ /
      Last update: 2012-11-23 00:01    [W:4.089 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site