lkml.org 
[lkml]   [2012]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, UV: integer wrap bug in uv_hub_ipi_value()
On Tue, Nov 20, 2012 at 11:07:25AM -0600, Russ Anderson wrote:
> The issue isn't "ulong" vs "unsigned long". The issue
> is int is 32 bit and long is 64 bit on x86_64. Your
> patch is casting the value as an "unsigned long" (64 bit
> on x86_64) into an int (32 bit). I don't think that
> was your intent.

Wait what? I only did int => long casts, not the other way around.

It occured to me to use u64 but this code is only compiled on x86_64
and I wrote my patch to match the surrounding context.

regards,
dan carpenter


\
 
 \ /
  Last update: 2012-11-21 09:21    [W:1.508 / U:10.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site