Messages in this thread | | | Date | Wed, 21 Nov 2012 10:39:56 +0300 | From | Dan Carpenter <> | Subject | Re: [patch] x86, UV: integer wrap bug in uv_hub_ipi_value() |
| |
On Tue, Nov 20, 2012 at 11:07:25AM -0600, Russ Anderson wrote: > The issue isn't "ulong" vs "unsigned long". The issue > is int is 32 bit and long is 64 bit on x86_64. Your > patch is casting the value as an "unsigned long" (64 bit > on x86_64) into an int (32 bit). I don't think that > was your intent.
Wait what? I only did int => long casts, not the other way around.
It occured to me to use u64 but this code is only compiled on x86_64 and I wrote my patch to match the surrounding context.
regards, dan carpenter
| |