lkml.org 
[lkml]   [2012]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started
Date
Hi Jason,

Thanks for the updated patch!
Sorry, I have one really minor remark left:

> + if (rc) {
> + dev_err(chip->dev,
> + "A TPM error (%d) occurred attempting to determine the timeouts\n",

rc is a ssize_t here and when compiling with C=1 I get
drivers/char/tpm/tpm.c:582:4: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ssize_t' [-Wformat]

Care to change to
> + "A TPM error (%zd) occurred attempting to determine the timeouts\n",

Sorry that I didn't spot it earlier.


Thanks,
Peter



\
 
 \ /
  Last update: 2012-11-21 21:41    [W:0.150 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site