Messages in this thread | | | From | Peter Hüwe <> | Subject | Re: [PATCH v4] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started | Date | Wed, 21 Nov 2012 21:17:54 +0100 |
| |
Hi Jason,
Thanks for the updated patch! Sorry, I have one really minor remark left:
> + if (rc) { > + dev_err(chip->dev, > + "A TPM error (%d) occurred attempting to determine the timeouts\n",
rc is a ssize_t here and when compiling with C=1 I get drivers/char/tpm/tpm.c:582:4: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ssize_t' [-Wformat]
Care to change to > + "A TPM error (%zd) occurred attempting to determine the timeouts\n",
Sorry that I didn't spot it earlier.
Thanks, Peter
| |