lkml.org 
[lkml]   [2012]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC 09/12] userns: Convert ocfs2 to use kuid and kgid where appropriate
    On Tue, Nov 20, 2012 at 04:43:37AM -0800, Eric W. Biederman wrote:
    > --- a/fs/ocfs2/file.c
    > +++ b/fs/ocfs2/file.c
    > @@ -1116,7 +1116,8 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)
    > (unsigned long long)OCFS2_I(inode)->ip_blkno,
    > dentry->d_name.len, dentry->d_name.name,
    > attr->ia_valid, attr->ia_mode,
    > - attr->ia_uid, attr->ia_gid);
    > + from_kuid(&init_user_ns, attr->ia_uid),
    > + from_kgid(&init_user_ns, attr->ia_gid));

    Dear Eric,
    I have a similar question about init_user_ns to Dave. As far as
    I can tell, using init_user_ns here means we'll never get translations
    based on the current process namespace. It just so happens that
    include/linux/user_namespace.h doesn't allow new namespaces yet, but I
    can't see why we would propagate that knowledge elsewhere.
    Is there some magic about when init_user_ns should be used
    regardless?

    Joel

    --

    Brain: I shall pollute the water supply with this DNAdefibuliser,
    turning everyone into mindless slaves.
    Pinky: What about the people who drink bottled water?
    Brain: Pinky, people who pay 5 dollars for a bottle of water are
    already mindless slaves.

    http://www.jlbec.org/
    jlbec@evilplan.org


    \
     
     \ /
      Last update: 2012-11-21 21:41    [W:3.679 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site