lkml.org 
[lkml]   [2012]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: lpc_ich: one uninitialized cell is no error
Hi Paul,

On Mon, Nov 19, 2012 at 09:04:11PM +0100, Paul Bolle wrote:
> At every boot of an (outdated) laptop lpc_ich prints an error:
> lpc_ich 0000:00:1f.0: I/O space for GPIO uninitialized
>
> But if one looks at lpc_ich's probe function one notices that the code
> only cares if both lpc_ich_init_wdt() and lpc_ich_init_gpio() fail to
> add any cells. So stop treating the failure to add a single cell as an
> error. Those messages can be printed at notice level. And then only warn
> if no cells were added.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) This patch was written on top of v3.7-rc4 and tested on v3.6.7.
>
> 1) Please note that this patch prints a warning when no MFD cells are
> added at all. I didn't make that an error because I'm not sure there's
> anything one can do if this happens. Is there?
>
> drivers/mfd/lpc_ich.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2012-11-21 18:21    [W:0.041 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site