lkml.org 
[lkml]   [2012]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] tty: vt: Remove redundant null check before kfree.
On Wed, Nov 21, 2012 at 10:49:07AM +0530, Sachin Kamat wrote:
> kfree on a NULL pointer is a no-op.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/tty/vt/consolemap.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c
> index 2aaa0c2..248381b 100644
> --- a/drivers/tty/vt/consolemap.c
> +++ b/drivers/tty/vt/consolemap.c
> @@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir *p)
> kfree(p->inverse_translations[i]);
> p->inverse_translations[i] = NULL;
> }
> - if (p->inverse_trans_unicode) {
> - kfree(p->inverse_trans_unicode);
> - p->inverse_trans_unicode = NULL;
> - }
> + kfree(p->inverse_trans_unicode);
> + p->inverse_trans_unicode = NULL;

kfree with NULL is a no-op, but the line after that just caused a kernel
crash if it was NULL, so I can't accept this type of thing.

Please be more careful.

What's with the patches@linaro.org email address? What is that for?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-11-21 16:21    [W:0.459 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site