Messages in this thread | | | Date | Wed, 21 Nov 2012 07:41:06 -0600 | From | Rob Herring <> | Subject | Re: [PATCH] of/i2c: support more interrupt specifiers |
| |
On 11/21/2012 02:58 AM, Bongkyu Kim wrote: > This patch supports more interrupt specifiers for i2c client.
Why?
> Signed-off-by: Bongkyu Kim <bongkyu.kim@lge.com> > --- > drivers/of/of_i2c.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c > index 3550f3b..c6d9b7e 100644 > --- a/drivers/of/of_i2c.c > +++ b/drivers/of/of_i2c.c > @@ -34,6 +34,7 @@ void of_i2c_register_devices(struct i2c_adapter *adap) > struct dev_archdata dev_ad = {}; > const __be32 *addr; > int len; > + int nr = 0; > > dev_dbg(&adap->dev, "of_i2c: register %s\n", node->full_name); > > @@ -57,7 +58,9 @@ void of_i2c_register_devices(struct i2c_adapter *adap) > continue; > } > > - info.irq = irq_of_parse_and_map(node, 0); > + info.irq = irq_of_parse_and_map(node, nr++); > + while (irq_of_parse_and_map(node, nr)) > + nr++;
What's the point if you are just discarding the interrupt number? If this is needed, then shouldn't you fix i2c_board_info first?
Rob
> info.of_node = of_node_get(node); > info.archdata = &dev_ad; > >
| |