Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [RFC PATCH] mm: trace filemap add and del | Date | Wed, 21 Nov 2012 11:38:00 +0100 |
| |
Dave Chinner <david@fromorbit.com> writes: > We actually have an informal convention for formating filesystem > trace events, and that is to use the device number.... > >> >> > + ), >> > + >> > + TP_printk("page=%p pfn=%lu blk=%d:%d inode+ofs=%lu+%lu", > > ... and to prefix messages like: > > TP_printk("dev %d:%d ino 0x%llx .... > MAJOR(__entry->dev), MINOR(__entry->dev), Right, it's sensible. I'll include that for patch V2.
> XFS, ext3/4, jbd/jdb2 and gfs2 follow this convention, so we should > keep propagating that pattern in the name of consistency, rather > than having different trace formats for different parts of the > VFS/FS layers... Very true.
Cheers.
-- Robert
| |