Messages in this thread | | | Date | Tue, 20 Nov 2012 12:13:44 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/3] perf session: Add perf_session__delete_env |
| |
Em Tue, Nov 20, 2012 at 05:31:15PM +0800, Feng Tang escreveu: > +static void perf_session__delete_env(struct perf_session *self) > +{ > + struct perf_session_env *env = &self->header.env; > + > + free(env->hostname); > + free(env->os_release); > + free(env->version); > + free(env->arch); > + free(env->cpu_desc); > + free(env->cpuid); > + > + free(env->cmdline); > + free(env->sibling_cores); > + free(env->sibling_threads); > + free(env->numa_nodes); > + free(env->pmu_mappings); > +}
The object being deleted is a perf_session_env, so please make it perf_session_env__delete(struct perf_session_env *env), and avoid using 'self'.
- Arnaldo
| |