lkml.org 
[lkml]   [2012]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3, v3] AMD64 EDAC: Cleanup type usage to be consistent
    On Mon, Nov 19, 2012 at 06:02:48PM +0800, Daniel J Blueman wrote:
    > As the Northbridge IDs are at most 16-bits, use the same type
    > consistently and cleanup some indexes to use smaller types.
    >
    > v2: Drop changes for later cleanups
    > v3: Further changes suggested by Boris
    >
    > Signed-off-by: Daniel J Blueman <daniel@numascale-asia.com>
    > ---
    > arch/x86/include/asm/amd_nb.h | 2 +-
    > arch/x86/include/asm/processor.h | 2 +-
    > arch/x86/kernel/cpu/amd.c | 4 ++--
    > drivers/edac/amd64_edac.c | 16 ++++++++--------
    > drivers/edac/amd64_edac.h | 6 +++---
    > 5 files changed, 15 insertions(+), 15 deletions(-)
    >
    > diff --git a/arch/x86/include/asm/amd_nb.h b/arch/x86/include/asm/amd_nb.h
    > index 9f5532a..b0815a0 100644
    > --- a/arch/x86/include/asm/amd_nb.h
    > +++ b/arch/x86/include/asm/amd_nb.h
    > @@ -76,7 +76,7 @@ static inline bool amd_nb_has_feature(unsigned feature)
    > return ((amd_northbridges.flags & feature) == feature);
    > }
    >
    > -static inline struct amd_northbridge *node_to_amd_nb(int node)
    > +static inline struct amd_northbridge *node_to_amd_nb(u16 node)
    > {
    > return (node < amd_northbridges.num) ? &amd_northbridges.nb[node] : NULL;
    > }

    You have a hunk in patch 1/3 changing the argument being passed to this
    function to u16 but you're changing the actual function right here, in
    3/3, which is strange and easy to puzzle a potential reviewer.

    As a rule of thumb: always do your changes to the functions and their callsites
    in one patch so that they belong together and can be reviewed easily.

    Thanks.

    --
    Regards/Gruss,
    Boris.


    \
     
     \ /
      Last update: 2012-11-20 16:41    [W:2.523 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site