lkml.org 
[lkml]   [2012]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] ARM: oprofile: add A5/A7/A15 entries in op_perf_name
Will,

On 05.11.12 11:31:03, Will Deacon wrote:
> > diff --git a/arch/arm/oprofile/common.c b/arch/arm/oprofile/common.c
> > index 99c63d4b..ec10db1 100644
> > --- a/arch/arm/oprofile/common.c
> > +++ b/arch/arm/oprofile/common.c
> > @@ -37,8 +37,11 @@ static struct op_perf_name {
> > { "xscale1", "arm/xscale2" },
> > { "v6", "arm/armv6" },
> > { "v6mpcore", "arm/mpcore" },
> > + { "ARMv7 Cortex-A5", "arm/armv7-ca5" },
> > + { "ARMv7 Cortex-A7", "arm/armv7-ca7" },
> > { "ARMv7 Cortex-A8", "arm/armv7" },
> > { "ARMv7 Cortex-A9", "arm/armv7-ca9" },
> > + { "ARMv7 Cortex-A15", "arm/armv7-ca15" },
> > };

> I'd rather not go down this route now that we have the operf tool as part of
> oprofile, which can use the perf syscall directly and doesn't need this
> string translation.

since this is just an update of cpu detection I would be willing to
include this into kernel code anyway.

We could further move the cpu detection to userspace if perf_event
exists. We let the kernel enable oprofile with cpu_type="unknown".
User space then could either bind mount the file (user could do this
manually) or we implement to write to cpu_type. Doing so oprofile
could use in-kernel perf_events if it exists always as fallback.

Any thoughts?

-Robert


\
 
 \ /
  Last update: 2012-11-20 15:01    [W:0.064 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site