Messages in this thread | | | Subject | Re: [PATCH] Yama: remove locking from delete path | From | Tetsuo Handa <> | Date | Tue, 20 Nov 2012 21:24:49 +0900 |
| |
Kees Cook wrote: > Instead of locking the list during a delete, mark entries as invalid > and trigger a workqueue to clean them up. This lets us easily handle > task_free from interrupt context.
> @@ -57,9 +80,12 @@ static int yama_ptracer_add(struct task_struct *tracer, > > added->tracee = tracee; > added->tracer = tracer; > + added->invalid = false; > > - spin_lock_bh(&ptracer_relations_lock); > + spin_lock(&ptracer_relations_lock);
Can't you use spin_lock_irqsave(&ptracer_relations_lock, flags); spin_unlock_irqrestore(&ptracer_relations_lock, flags); instead of adding ->invalid ?
| |