Messages in this thread | | | Date | Fri, 2 Nov 2012 14:39:50 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 3/5] staging: zcache2+ramster: enable zcache2 to be built/loaded as a module |
| |
On Wed, Oct 31, 2012 at 08:07:52AM -0700, Dan Magenheimer wrote: > Allow zcache2 to be built/loaded as a module. Note runtime dependency > disallows loading if cleancache/frontswap lazy initialization patches > are not present. Zsmalloc support has not yet been merged into zcache2 > but, once merged, could now easily be selected via a module_param. > > If built-in (not built as a module), the original mechanism of enabling via > a kernel boot parameter is retained, but this should be considered deprecated. > > Note that module unload is explicitly not yet supported.
I had an issue putting it on v3.7-rc3 with the Kconfig. Not sure why as it looks exactly the same.
The patch looks good, however..
> @@ -1812,9 +1846,28 @@ static int __init zcache_init(void) > } > if (ramster_enabled) > ramster_init(!disable_cleancache, !disable_frontswap, > - frontswap_has_exclusive_gets); > + frontswap_has_exclusive_gets, > + !disable_frontswap_selfshrink); > out: > return ret; > }
.. ramster_init change is in the next patch. So it looks like the patch order is a bit mismatched.
| |