Messages in this thread | | | Date | Fri, 02 Nov 2012 16:57:07 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors |
| |
>>> On 02.11.12 at 17:44, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > --- a/arch/x86/include/asm/xen/hypercall.h > +++ b/arch/x86/include/asm/xen/hypercall.h > @@ -359,18 +359,14 @@ HYPERVISOR_update_va_mapping(unsigned long va, pte_t new_val, > return _hypercall4(int, update_va_mapping, va, > new_val.pte, new_val.pte >> 32, flags); > } > +extern int __must_check xen_HYPERVISOR_event_channel_op_compat(int, void *);
Why don't you drop the HYPERVISOR_ now that you added the xen_?
>... > +EXPORT_SYMBOL_GPL(xen_HYPERVISOR_event_channel_op_compat);
While this export is necessary, ...
>... > +EXPORT_SYMBOL_GPL(xen_HYPERVISOR_physdev_op_compat);
... I would recommend not adding this one without need.
Jan
| |