lkml.org 
[lkml]   [2012]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 21/21] TTY: move tty buffers to tty_port
On 11/02/2012 05:07 PM, Sasha Levin wrote:
> On Fri, Nov 2, 2012 at 11:51 AM, Jiri Slaby <jslaby@suse.cz> wrote:
>> On 10/31/2012 04:59 PM, Sasha Levin wrote:
>>> So you probably want a lot more than 100k syscalls, why limit it at
>>> all actually?
>>
>> I unset the limit but I still can't reproduce...
>>
>>> I've attached my .config for the guest kernel as reference.
>>
>> Even using this config does not help to reproduce that.
>>
>> Do you use some special trinity params?
>
> Not really:
>
> ./trinity -m --quiet --dangerous -l off

Oh, you run that as root??

> Can I add something to my kernel to provide more info when it happens?

Maybe the attached patch can tell us more...

--
js
suse labs
From 36ad8f281846ef395e1969fc2af324c5edb13043 Mon Sep 17 00:00:00 2001
From: Jiri Slaby <jslaby@suse.cz>
Date: Sun, 28 Oct 2012 21:42:02 +0100
Subject: [PATCH] tty BUF DEBUG

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/tty/tty_buffer.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index 45d9161..c70274b 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -371,6 +371,7 @@ void tty_schedule_flip(struct tty_struct *tty)
if (buf->tail != NULL)
buf->tail->commit = buf->tail->used;
spin_unlock_irqrestore(&buf->lock, flags);
+ WARN_RATELIMIT(tty->port->itty == NULL, "HUH\n");
schedule_work(&buf->work);
}
EXPORT_SYMBOL(tty_schedule_flip);
@@ -566,6 +567,7 @@ void tty_flip_buffer_push(struct tty_struct *tty)
buf->tail->commit = buf->tail->used;
spin_unlock_irqrestore(&buf->lock, flags);

+ WARN_RATELIMIT(tty->port->itty == NULL, "HUH\n");
if (tty->low_latency)
flush_to_ldisc(&buf->work);
else
--
1.8.0
\
 
 \ /
  Last update: 2012-11-02 18:01    [W:0.062 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site