Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [patch 01/10] scsi: make __scsi_alloc_queue numa-aware | Date | Fri, 02 Nov 2012 10:19:52 -0400 |
| |
Bart Van Assche <bvanassche@acm.org> writes:
> On 10/30/12 21:14, Jeff Moyer wrote: >> Pass the numa node id set in the Scsi_Host on to blk_init_queue_node >> in order to keep all allocations local to the numa node the device is >> closest to. >> >> Signed-off-by: Jeff Moyer <jmoyer@redhat.com> >> --- >> drivers/scsi/scsi_lib.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c >> index da36a3a..8662a09 100644 >> --- a/drivers/scsi/scsi_lib.c >> +++ b/drivers/scsi/scsi_lib.c >> @@ -1664,7 +1664,7 @@ struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost, >> struct request_queue *q; >> struct device *dev = shost->dma_dev; >> >> - q = blk_init_queue(request_fn, NULL); >> + q = blk_init_queue_node(request_fn, NULL, shost->numa_node); >> if (!q) >> return NULL; > > Hello Jeff, > > I haven't seen the patch that introduces numa_node in struct Scsi_Host > nor the cover letter of this patch series ? Have these been posted on > the linux-scsi mailing list ?
Hi, Bart,
Wow, looks like I left out the first patch! The cover letter I think only went to lkml. I have to do a repost, so I'll be sure to send the cover to linux-scsi as well, and CC you (and credit you for the idea, which I totally forgot to do). I'll send a repost out today.
Cheers, Jeff
| |