Messages in this thread Patch in this message | | | Date | Mon, 19 Nov 2012 14:21:57 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation |
| |
On Mon, 19 Nov 2012 10:38:53 +0900 Jingoo Han <jg1.han@samsung.com> wrote:
> This patch removes remove an unnecessary line continuation in > pm860x_backlight_probe(). Also, a checkpatch warning is fixed > as below: > > WARNING: Avoid unnecessary line continuations > > --- a/drivers/video/backlight/88pm860x_bl.c > +++ b/drivers/video/backlight/88pm860x_bl.c > @@ -228,7 +228,7 @@ static int pm860x_backlight_probe(struct platform_device *pdev) > sprintf(name, "backlight-%d", pdev->id); > data->port = pdev->id; > data->chip = chip; > - data->i2c = (chip->id == CHIP_PM8606) ? chip->client \ > + data->i2c = (chip->id == CHIP_PM8606) ? chip->client > : chip->companion; > data->current_brightness = MAX_BRIGHTNESS; > if (pm860x_backlight_dt_init(pdev, data, name)) {
It's still pretty ugly, but looky here:
diff -puN drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix drivers/video/backlight/88pm860x_bl.c --- a/drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix +++ a/drivers/video/backlight/88pm860x_bl.c @@ -228,8 +228,7 @@ static int pm860x_backlight_probe(struct sprintf(name, "backlight-%d", pdev->id); data->port = pdev->id; data->chip = chip; - data->i2c = (chip->id == CHIP_PM8606) ? chip->client - : chip->companion; + data->i2c = (chip->id == CHIP_PM8606) ? chip->client : chip->companion; data->current_brightness = MAX_BRIGHTNESS; if (pm860x_backlight_dt_init(pdev, data, name)) { if (pdata) { _
| |