Messages in this thread | | | From | "Liu, Chuansheng" <> | Subject | RE: [PATCH] mmc,sdio: Fix the panic due to devname NULL when calling pm_runtime_set_active() | Date | Mon, 19 Nov 2012 08:01:27 +0000 |
| |
> -----Original Message----- > From: Ohad Ben-Cohen [mailto:ohad@wizery.com] > Sent: Monday, November 19, 2012 3:47 PM > To: Liu, Chuansheng > Cc: Chris Ball; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] mmc,sdio: Fix the panic due to devname NULL when > calling pm_runtime_set_active() > > On Mon, Nov 19, 2012 at 7:57 AM, Liu, Chuansheng > <chuansheng.liu@intel.com> wrote: > > Rechecked these codes, the trace event runtime_pm_status is added newly, > this is different with vanilla > > Linux. > > Not sure I'm following - can you point out which tree are you working with ? Sorry, it is added internally for debugging purpose. > > > So I still think that calling pm_runtime_set_active is not safe when dev_name > is NULL. > > If you agree this point, I can refine the code that moving "init the dev_name " > from mmc_add_card > > to mmc_sdio_init_card. > > This sounds more reasonable. I will try a V2 patch soon, thanks.
> > Thanks, > Ohad.
| |