lkml.org 
[lkml]   [2012]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: removal of sysfs wext extension broke on F16
Hi Sven,

On Sat, Nov 17, 2012 at 9:32 AM, Sven-Haegar Koch <haegar@sdinet.de> wrote:
> On Fri, 16 Nov 2012, Johannes Berg wrote:
>
>> On Fri, 2012-11-16 at 21:36 +0100, Johannes Berg wrote:
>> > On Fri, 2012-11-16 at 21:35 +0100, Johannes Berg wrote:
>> > > On Fri, 2012-11-16 at 10:20 -0800, Linus Torvalds wrote:
>> > > > On Tue, Nov 13, 2012 at 12:27 AM, Johannes Berg
>> > > > <johannes@sipsolutions.net> wrote:
>> > > > >
>> > > > > Should I revert it and send it in my next pull request?
>> > > >
>> > > > Please do. Or perhaps we could just add the directory back, without
>> > > > the actual entries, if that is sufficient..
>> > >
>> > > Yeah, that does seem to be sufficient, I'll queue up the patch below.
>> >
>> > Err, no, wishful thinking. I need a *little* bit more for sysfs to work.
>>
>> This works, sorry about that.
>
>> +#if IS_ENABLED(CONFIG_WIRELESS_EXT) || IS_ENABLED(CONFIG_CFG80211)
>> +static struct attribute *wireless_attrs[] = {
>> + NULL
>> +};
>> +
>> +static struct attribute_group wireless_group = {
>> + .name = "wireless",
>> + .attrs = wireless_attrs,
>> +};
>> +#endif
>> #endif /* CONFIG_SYSFS */
>>
>
> How about a small comment in the source why it is there? I suppose
> otherwise in a year or two someone will find it, see "WTF? Useless
> empty directory?" and try to remove it again...

Hopefully by then Fedora's networking scripts won't need it =)

Thanks,

--
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/


\
 
 \ /
  Last update: 2012-11-17 12:01    [W:0.041 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site