lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] acpi_system_write_wakeup_device(): fix error check for unsigned variable.
Date
The LEN variable is unsigned, therefore checking whether it is less than 0 is
useless.

Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
---
drivers/acpi/proc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 27adb09..37871a7 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -366,8 +366,6 @@ acpi_system_write_wakeup_device(struct file *file,

if (len > 4)
len = 4;
- if (len < 0)
- return -EFAULT;

if (copy_from_user(strbuf, buffer, len))
return -EFAULT;
--
1.7.10.4


\
 
 \ /
  Last update: 2012-11-17 03:41    [W:0.096 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site