lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] staging: wlags49_h2: mdd.h: fixes tons of coding style issues
From
Will do.  Just a quick question: Is it acceptable to submit small
patches even if the main file still fails the checkpatch,pl script?
i.e. is it OK to fix e.g. the first 20 instances of C99 // comment
usage, even if 200 remain afterwards, and then fix them later?

Johan

On 16 November 2012 19:06, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Nov 16, 2012 at 06:55:11PM +0200, Johan Meiring wrote:
>> This commit sorts out a ton of styling issues, including the use of
>> C99 // comments, spaces before and after tabs, etc. I also took the
>> time to align stuff a little more neatly using tabs. The file is
>> nowhere near ready, but it's a start.
>>
>> Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
>> ---
>> drivers/staging/wlags49_h2/mdd.h | 1593 +++++++++++++++++++-------------------
>> 1 file changed, 797 insertions(+), 796 deletions(-)
>
> A patch this big is almost impossible to review, sorry. Please break it
> up into smaller pieces.
>
> thanks,
>
> greg k-h


\
 
 \ /
  Last update: 2012-11-17 01:21    [W:0.216 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site