lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3 UPDATED] i2c / ACPI: add ACPI enumeration support
On Fri, 16 Nov 2012 19:28:28 +0200, Mika Westerberg wrote:
> On Fri, Nov 16, 2012 at 05:47:53PM +0100, Jean Delvare wrote:
> > Hi Mika,
> >
> > On Fri, 16 Nov 2012 17:23:32 +0200, Mika Westerberg wrote:
> > > Here's the updated version where we handle 10-bit addresses properly
> > > (hopefully).
> > > (...)
> > > +static int acpi_i2c_find_device(struct device *dev, acpi_handle *handle)
> > > +{
> > > (...)
> > > + memset(&i2c_find, 0, sizeof(i2c_find));
> > > + i2c_find.addr = client->addr;
> > > + if (client->flags & I2C_CLIENT_TEN)
> > > + i2c_find.access_mode = ACPI_I2C_10BIT_MODE;
> >
> > This works because you are lucky and ACPI_I2C_7BIT_MODE has value 0,
> > but for correctness I'd rather add:
> >
> > else
> > i2c_find.access_mode = ACPI_I2C_7BIT_MODE;
>
> Right, sorry about that. The patch below should address this as well.
> (...)

Yes, looks good.

--
Jean Delvare


\
 
 \ /
  Last update: 2012-11-17 00:01    [W:0.657 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site