Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC PATCH v2 0/3] acpi: Introduce prepare_remove device operation | Date | Fri, 16 Nov 2012 22:43:59 +0100 |
| |
On Thursday, November 15, 2012 11:22:47 AM Vasilis Liaskovitis wrote: > As discussed in https://patchwork.kernel.org/patch/1581581/ > the driver core remove function needs to always succeed. This means we need > to know that the device can be successfully removed before acpi_bus_trim / > acpi_bus_hot_remove_device are called. This can cause panics when OSPM-initiated > eject or driver unbind of memory devices fails e.g with: > > echo 1 >/sys/bus/pci/devices/PNP0C80:XX/eject > echo "PNP0C80:XX" > /sys/bus/acpi/drivers/acpi_memhotplug/unbind > > since the ACPI core goes ahead and ejects the device regardless of whether the > the memory is still in use or not.
So the question is, does the ACPI core have to do that and if so, then why?
Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |