Messages in this thread | | | Date | Fri, 16 Nov 2012 21:16:55 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove |
| |
On Wed, Nov 14, 2012 at 12:58:14PM +0100, Alban Bedel wrote: [...] > static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev) > { > struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev); > + int i;
This should rather be unsigned int since pwm_chip.npwm is unsigned as well.
> + > + for (i = 0 ; i < lpc32xx->chip.npwm ; i += 1)
No space before ';' and "i++" please.
Thierry [unhandled content-type:application/pgp-signature] | |