lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ipack: move header files to include/linux
From
Date
On Fri, 2012-11-16 at 19:14 +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote:
> > On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote:
> > > Move ipack header files to include/linux/ directory where they belong to.
> >
> > Why do these belong in include/linux?
>
> They are used for other drivers that could be in other directories.

But are not currently.

> > What's wrong with path relative includes?
>
> There is nothing wrong with relative includes. It's just to do the
> things as other subsystems do: keeping the bus' header file in
> include/linux directory.
>
> Is this approach wrong for this case?

There's enough clutter in include/linux, so until these
includes are used by other directory drivers, I think so,
yes.

cheers, Joe



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-11-16 20:41    [W:0.073 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site