Messages in this thread | | | Subject | Re: [PATCH 2/5] drivers/net/wireless/ti/wlcore/main.c: eliminate possible double power off | From | Luciano Coelho <> | Date | Fri, 16 Nov 2012 20:18:14 +0200 |
| |
On Sun, 2012-10-21 at 12:52 +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > The function wl12xx_set_power_on is only called twice, once in > wl12xx_chip_wakeup and once in wl12xx_get_hw_info. On the failure of the > call in wl12xx_chip_wakeup, the containing function just returns, but on > the failure of the call in wl12xx_get_hw_info, the containing function > calls wl1271_power_off. This does not seem necessary, because if > wl12xx_set_power_on has set the power on and then fails, it has already > turned the power off.
[...]
Applied and pushed, thanks!
-- Luca.
| |