Messages in this thread | | | Date | Fri, 16 Nov 2012 12:35:59 +0530 | Subject | Re: [PATCH 07/14] pinctrl: SPEAr: Update error check for unsigned variables | From | viresh kumar <> |
| |
On Fri, Nov 16, 2012 at 12:20 PM, Tushar Behera <tushar.behera@linaro.org> wrote: > Checking '< 0' for unsigned variables always returns false. For error > codes, use IS_ERR_VALUE() instead. > > CC: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Tushar Behera <tushar.behera@linaro.org> > --- > drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c > index 1044ad3..9e0c731 100644 > --- a/drivers/pinctrl/spear/pinctrl-plgpio.c > +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c > @@ -283,7 +283,7 @@ static int plgpio_to_irq(struct gpio_chip *chip, unsigned offset) > { > struct plgpio *plgpio = container_of(chip, struct plgpio, chip); > > - if (plgpio->irq_base < 0) > + if (IS_ERR_VALUE(plgpio->irq_base)) > return -EINVAL; > > return irq_find_mapping(plgpio->irq_domain, offset);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
| |