lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] staging: wlags49_h2: ap_h2: fixes coding style issues
On Fri, Nov 16, 2012 at 06:52:39PM +0200, Johan Meiring wrote:
> This corrects several instances of spaces before tabs and incorrect spacing around "*" characters. It also fixes some 80+ character line length issues, but the majority of such cases have been left as is, as this was probably the author's intention.

Please wrap your changelog lines at the properly length (i.e. 72
columns)

Also, please only do one thing per patch. You are doing multiple things
here, which makes it hard to review.

Same goes for the other patches in this series, please break it up into
smaller steps, which makes for more patches, but it makes it easier to
review to ensure you didn't do something wrong.

Care to redo this and resend it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-11-16 18:41    [W:0.047 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site