Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 16 Nov 2012 07:45:29 -0800 | Subject | Re: [PATCH] autofs4 - use simple_empty() for empty directory check |
| |
On Thu, Nov 15, 2012 at 8:15 PM, Ian Kent <ikent@redhat.com> wrote: > > +static inline int __simple_empty(struct dentry *dentry) > +{
This seems completely bogus.
It's a duplicate of the existing fs/libfs.c "simple_empty()" function, but without taking the outer lock.
That kind of code duplication - and doing it in a totally different file, and making it look autofs-specific - seems entirely wrong.
Linus
| |