lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/6] dma: ipu_idmac: reuse is_slave_xfer helper
From
On Fri, Nov 16, 2012 at 3:56 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Fri, Nov 16, 2012 at 03:59:18PM +0200, Andy Shevchenko wrote:
>
> -ENOCOMMITLOG ??

I don't see much sense to add anything here, but I will do for the patch v2.

>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> ---
>> drivers/dma/ipu/ipu_idmac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
>> index 6585537..c8d0254 100644
>> --- a/drivers/dma/ipu/ipu_idmac.c
>> +++ b/drivers/dma/ipu/ipu_idmac.c
>> @@ -1347,7 +1347,7 @@ static struct dma_async_tx_descriptor *idmac_prep_slave_sg(struct dma_chan *chan
>> chan->chan_id != IDMAC_IC_7)
>> return NULL;
>>
>> - if (direction != DMA_DEV_TO_MEM && direction != DMA_MEM_TO_DEV) {
>> + if (!is_slave_xfer(direction)) {
>> dev_err(chan->device->dev, "Invalid DMA direction %d!\n", direction);
>> return NULL;
>> }
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
> --
> balbi



--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2012-11-16 17:21    [W:0.124 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site