Messages in this thread | | | Date | Fri, 16 Nov 2012 17:27:33 +0200 | Subject | Re: [PATCH 1/6] dmaengine: introduce is_slave_xfer function | From | Andy Shevchenko <> |
| |
On Fri, Nov 16, 2012 at 4:03 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 16 November 2012 19:29, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> This function helps to distinguish the slave type of transfer by checking the >> direction parameter. >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: Nicolas Ferre <nicolas.ferre@atmel.com> >> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> >> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> --- >> include/linux/dmaengine.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h >> index 6402b18..3e1a9026 100644 >> --- a/include/linux/dmaengine.h >> +++ b/include/linux/dmaengine.h >> @@ -618,6 +618,11 @@ static inline int dmaengine_slave_config(struct dma_chan *chan, >> (unsigned long)config); >> } >> >> +static inline bool is_slave_xfer(enum dma_transfer_direction direction) >> +{ >> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); >> +} > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> > > Though i still have vote to include DMA_DEV_TO_DEV in thist list :)
I propose to do this later when we have a real user of it. Otherwise it requires to do additional (sometimes useless) checks.
-- With Best Regards, Andy Shevchenko
| |