Messages in this thread | | | Subject | Re: [PATCH v6 3/4] media: coda: use genalloc API | From | Philipp Zabel <> | Date | Fri, 16 Nov 2012 16:21:13 +0100 |
| |
Am Freitag, den 16.11.2012, 10:08 -0500 schrieb Paul Gortmaker: > On 12-11-16 05:30 AM, Philipp Zabel wrote: > > This patch depends on "genalloc: add a global pool list, > > allow to find pools by phys address", which provides the > > of_get_named_gen_pool function. > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > --- > > drivers/media/platform/Kconfig | 3 +-- > > drivers/media/platform/coda.c | 47 ++++++++++++++++++++++++++++------------ > > 2 files changed, 34 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index 181c768..09d45c6 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -130,10 +130,9 @@ if V4L_MEM2MEM_DRIVERS > > > > config VIDEO_CODA > > tristate "Chips&Media Coda multi-standard codec IP" > > - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC > > + depends on VIDEO_DEV && VIDEO_V4L2 > > What was the logic for reducing the dependency scope here? > Your commit log doesn't mention that at all, and when I see > things like that, I predict allyesconfig build failures, > unless there is a similar dependency elsewhere that isn't > visible in just the context of this patch alone. > > P.
iram_alloc and iram_free are i.MX specific wrappers around gen_pool_alloc and gen_pool_free, located in <mach/iram.h>. Those were responsible for the dependency in the first place.
> -- > > > select VIDEOBUF2_DMA_CONTIG > > select V4L2_MEM2MEM_DEV > > - select IRAM_ALLOC if SOC_IMX53 > > ---help--- > > Coda is a range of video codec IPs that supports > > H.264, MPEG-4, and other video formats. > > diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c > > index cd04ae2..f17b659 100644 > > --- a/drivers/media/platform/coda.c > > +++ b/drivers/media/platform/coda.c > > @@ -14,6 +14,7 @@ > > #include <linux/clk.h> > > #include <linux/delay.h> > > #include <linux/firmware.h> > > +#include <linux/genalloc.h> > > #include <linux/interrupt.h> > > #include <linux/io.h> > > #include <linux/irq.h> > > @@ -24,7 +25,6 @@ > > #include <linux/videodev2.h> > > #include <linux/of.h> > > > > -#include <mach/iram.h> [...]
After dropping the #include <mach/iram.h>, there is no need to depend on ARCH_MXC anymore.
regards Philipp
| |