Messages in this thread | | | Date | Fri, 16 Nov 2012 16:21:04 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH 1/6] dmaengine: introduce is_slave_xfer function |
| |
On Fri, Nov 16, 2012 at 03:59:14PM +0200, Andy Shevchenko wrote: > This function helps to distinguish the slave type of transfer by checking the > direction parameter. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > --- > include/linux/dmaengine.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 6402b18..3e1a9026 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -618,6 +618,11 @@ static inline int dmaengine_slave_config(struct dma_chan *chan, > (unsigned long)config); > } > > +static inline bool is_slave_xfer(enum dma_transfer_direction direction) > +{ > + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); > +}
I wonder if the above function need some prefix like dmaengine_is_slave_xfer()?
Otherwise looks fine to me.
| |