lkml.org 
[lkml]   [2012]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/43] mm: numa: Make pte_numa() and pmd_numa() a generic implementation
On 11/16/2012 06:22 AM, Mel Gorman wrote:
> It was pointed out by Ingo Molnar that the per-architecture definition of
> the NUMA PTE helper functions means that each supporting architecture
> will have to cut and paste it which is unfortunate. He suggested instead
> that the helpers should be weak functions that can be overridden by the
> architecture.
>
> This patch moves the helpers to mm/pgtable-generic.c and makes them weak
> functions. Architectures wishing to use this will still be required to
> define _PAGE_NUMA and potentially update their p[te|md]_present and
> pmd_bad helpers if they choose to make PAGE_NUMA similar to PROT_NONE.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>

Is uninlining these simple tests really the right thing to do,
or would they be better off as inlines in asm-generic/pgtable.h ?

--
All rights reversed


\
 
 \ /
  Last update: 2012-11-16 16:01    [W:0.158 / U:22.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site