Messages in this thread | | | Date | Fri, 16 Nov 2012 05:32:55 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: Add SystemBase Multi-2/PCI driver |
| |
On Fri, Nov 16, 2012 at 08:17:55AM -0500, Steven Rostedt wrote: > On Thu, 2012-11-15 at 21:08 -0800, Greg Kroah-Hartman wrote: > > On Thu, Nov 15, 2012 at 11:39:31PM -0500, Steven Rostedt wrote: > > > I ported the driver supplied by SystemBase to mainline. > > > > > > As the driver had MODULE_LICENSE("GPL") it is declared as a GPL module > > > and thus I have the right to distribute it upstream. Note, I did the > > > bare minimum to get it working. It still needs a lot of loving. > > > > Being in staging only requires 2 things, proper license, and it has to > > build. > > > > This fails on the second one: > > > > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0: > > drivers/staging/sb105x/sb_pci_mp.h:279:40: error: array type has incomplete element type > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_startup’: > > drivers/staging/sb105x/sb_pci_mp.c:546:26: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_shutdown’: > > drivers/staging/sb105x/sb_pci_mp.c:573:40: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_change_speed’: > > drivers/staging/sb105x/sb_pci_mp.c:596:14: error: wrong type argument to unary exclamation mark > > drivers/staging/sb105x/sb_pci_mp.c:599:10: error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’ > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_throttle’: > > drivers/staging/sb105x/sb_pci_mp.c:734:18: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_unthrottle’: > > drivers/staging/sb105x/sb_pci_mp.c:750:18: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_set_termios’: > > drivers/staging/sb105x/sb_pci_mp.c:1277:35: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c:1282:4: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_update_termios’: > > drivers/staging/sb105x/sb_pci_mp.c:1450:19: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_block_til_ready’: > > drivers/staging/sb105x/sb_pci_mp.c:1476:24: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c:1481:25: error: invalid type argument of ‘->’ (have ‘struct ktermios’) > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘multi_type’: > > drivers/staging/sb105x/sb_pci_mp.c:2763:14: error: bit-field ‘<anonymous>’ width not an integer constant > > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0: > > drivers/staging/sb105x/sb_pci_mp.c: At top level: > > drivers/staging/sb105x/sb_pci_mp.h:279:40: warning: ‘uart_config’ defined but not used [-Wunused-variable] > > drivers/staging/sb105x/sb_pci_mp.c: In function ‘multi_type’: > > drivers/staging/sb105x/sb_pci_mp.c:2766:1: warning: control reaches end of non-void function [-Wreturn-type] > > make[3]: *** [drivers/staging/sb105x/sb_pci_mp.o] Error 1 > > make[2]: *** [drivers/staging/sb105x] Error 2 > > make[1]: *** [drivers/staging] Error 2 > > Ah interesting, probably a missing dependency. Do you have a config I > can test against. It worked for me against 3.6.6 (the kernel that runs > the box with the card).
That's the issue, the tty layer has changed a bunch since 3.6, this was against 3.7-rc5. That is what has caused the build breakage here.
Redo this aginast 3.7-rc5 and we should be better off. If you really want to do this right, do this against the tty-next git tree, to catch all of the recent tty changes that will be going into 3.8.
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |